Electra: updated get_next_sync_committee_indices
#14164
Merged
+48
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestonvanloon
force-pushed
the
electra-updated-get_next_sync_committee_indices
branch
from
b61491f
to
9a7f4f3
Compare
prestonvanloon
force-pushed
the
electra-updated-get_next_sync_committee_indices
branch
from
9a7f4f3
to
8a7f27f
Compare
james-prysm
approved these changes
Jun 28, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
terencechain
approved these changes
Jul 1, 2024
prestonvanloon
deleted the
electra-updated-get_next_sync_committee_indices
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
ethereum/consensus-specs#3783
Which issues(s) does this PR fix?
Updates get_next_sync_committe_indices to use electra max eb.
Other notes for review
Reviewers may notice that this is more code branching in prior fork logic, which I have been against. I plan to revisit this after devnet-1 is feature complete.